fix: propagate storage errors instead of returning empty site#238
Merged
Conversation
S3 storage errors (misconfigured bucket, network failures) now propagate as proper errors instead of being silently swallowed and returning an empty site. Initial load failures surface as error responses (503 from HTTP server, thrown errors from napi bindings). Subsequent reload failures log a warning and keep serving stale data, avoiding downtime from transient errors. Fixes #237 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
yumike
force-pushed
the
fix/propagate-storage-errors
branch
from
01e869c to
12b76b8
Compare
yumike
added a commit
to rwdocs/backstage-plugins
that referenced
this pull request
Mar 24, 2026
Adopt changes from rwdocs/rw#238 where getNavigation() now throws on storage errors and renderPage() surfaces a distinct Storage error variant. Previously, misconfigured S3 or network failures would silently return empty navigation — now they propagate as ServiceUnavailableError (503). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
5 tasks
yumike
added a commit
to rwdocs/backstage-plugins
that referenced
this pull request
Mar 24, 2026
Adopt changes from rwdocs/rw#238 where getNavigation() now throws on storage errors and renderPage() surfaces a distinct Storage error variant. Previously, misconfigured S3 or network failures would silently return empty navigation — now they propagate as ServiceUnavailableError (503). Also bumps @rwdocs/core and @rwdocs/viewer to ^0.1.19. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
yumike
added a commit
to rwdocs/backstage-plugins
that referenced
this pull request
Mar 24, 2026
Adopt changes from rwdocs/rw#238 where getNavigation() now throws on storage errors and renderPage() surfaces a distinct Storage error variant. Previously, misconfigured S3 or network failures would silently return empty navigation — now they propagate as ServiceUnavailableError (503). Also bumps @rwdocs/core and @rwdocs/viewer to ^0.1.19. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RenderError::StorageandHandlerError::Storagevariants for proper error typing through the stackTest plan
MockStorage::with_scan_error()/set_scan_error()reload_if_needed,navigation,render,has_pageHandlerError::Storagereturning 503cargo test -p rw-site -p rw-storage -p rw-server)🤖 Generated with Claude Code